Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Replace Tabs with Spaces #7

Merged
merged 1 commit into from
Nov 13, 2014
Merged

Replace Tabs with Spaces #7

merged 1 commit into from
Nov 13, 2014

Conversation

JimBobSquarePants
Copy link

Spaces are a best fit for OSS code as it maintains consistency across different IDE's. :bowtie:

Spaces are a best fit for OSS code as it maintains consistency across
IDE's
@leekelleher
Copy link
Collaborator

Different IDEs? Visual Studio and ... ? 😜

I'll review tomorrow.

@mattbrailsford - any comment?

@JimBobSquarePants
Copy link
Author

I dunno, Sublime, Xamarin or maybe if you're feeling all out ballsy, Notepad 😉

@mattbrailsford
Copy link
Collaborator

What's wrong with being different? :)

Honestly not bothered either way.

@leekelleher leekelleher self-assigned this Nov 13, 2014
@leekelleher
Copy link
Collaborator

The IDE debate is a moot point, as with this small Umbraco library, there's only going to be a handful of devs looking at it... in Visual Studio.

However, I'm all for collaboration and if the general consensus is that OSS projects use spaces over tabs, then I'm fine with that. :shipit:


What I do when working on other projects that use spaces, I have the "Untabify Selected Lines" option wired up to a keyboard short-cut (CTRL+K,CTRL+T) ... then before I'd save a page, I'd go: CTRL+A, CTRL+K,CTRL+D, CTRL+K,CTRL+T ... a bit long winded, but it does the job - I'm sure there's a VS extension that can automatically do that, but I like the conscious control. :neckbeard:

leekelleher added a commit that referenced this pull request Nov 13, 2014
@leekelleher leekelleher merged commit 9c02b6b into umco:master Nov 13, 2014
@JimBobSquarePants JimBobSquarePants deleted the tabs-vs-spaces branch November 14, 2014 10:34
@leekelleher leekelleher modified the milestone: 0.5.0 Jan 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants