LIBFCREPO-1425. Remove per-row publishing/hiding from Plastron import #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed code from the “plastron-repo/src/plastron/jobs/importjob/__init__.py” file where the “publish” and “hidden” fields from individual CSV rows was used to publish/hide items. This included removing code from the “create_resource” method, which set the “umdaccess.Published” and “umdaccess.Hidden” RDF type for newly created items (which was problematic because it was setting the types without doing other “publish” activities such as minting a new handle). Updated the unit tests, and the “plastron-cli/docs/import.md” file (which had become out-of-date with the current options provided by the “import” command). Based on the changes in this issue, the “import” command only publishes via the “--publish” flag, which published all the items in the import. There is no way to “hide” (or make visible) an item via the “import” ommand – use the “publish” and “unpublish” commands instead (via the “--hide” and “--visible” flags). Added an ADR document, as the decision to remove the per-row use of the “PUBLISH” and “HIDDEN” fields by the “import” command seemed to rise to that level (from a philosophical/”what were we thinking” perspective). https://umd-dit.atlassian.net/browse/LIBFCREPO-1425
dsteelma-umd
force-pushed
the
feature/LIBFCREPO-1425
branch
from
cf65d16
to
5454e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed code from the
“plastron-repo/src/plastron/jobs/importjob/init.py” file where the “publish” and “hidden” fields from individual CSV rows was used to publish/hide items. This included removing code from the “create_resource” method, which set the “umdaccess.Published” and “umdaccess.Hidden” RDF type for newly created items (which was problematic because it was setting the types without doing other “publish” activities such as minting a new handle).
Updated the unit tests, and the “plastron-cli/docs/import.md” file (which had become out-of-date with the current options provided by the “import” command).
Based on the changes in this issue, the “import” command only publishes via the “--publish” flag, which published all the items in the import. There is no way to “hide” (or make visible) an item via the “import” ommand – use the “publish” and “unpublish” commands instead (via the “--hide” and “--visible” flags).
Added an ADR document, as the decision to remove the per-row use of the “PUBLISH” and “HIDDEN” fields by the “import” command seemed to rise to that level (from a philosophical/”what were we thinking” perspective).
https://umd-dit.atlassian.net/browse/LIBFCREPO-1425