LIBFCREPO-1438. Modified Import "make-templates" to handle mapped hea… #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders Modified the "--make-template" functionality of the "import" command to handle model HEADER_MAPs with dictionary values, by adding each value in the dictionary as a CSV header field (regardless of the key). This was done by introducing a "parse_model_header_map" to the "plastron-cli/src/plastron/cli/commands/importcommand.py" file, and checking to see if the header value is a simple string, or a dictionary, and taking appropriate action. The "write_model_template" was then updated to use the new method. Added a unit tests using the "Item", "Letter", "Poster", and "Issue" models to verify functionality. This results in coupling between the tests and the HEADER_MAP in each of the models, but hopefully it will be simple to update the tests as needed as the header fields evolve. https://umd-dit.atlassian.net/browse/LIBFCREPO-1438
dsteelma-umd
force-pushed
the
feature/LIBFCREPO-1438
branch
from
a5d8b27
to
3748b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ders
Modified the "--make-template" functionality of the "import" command to handle model HEADER_MAPs with dictionary values containing "label" and "same_as" keys, which are converted to individual CSV header fields.
This was done by introducing a "parse_model_header_map" to the "plastron-cli/src/plastron/cli/commands/importcommand.py" file, and checking to see if the header value is a simple string, or a dictionary, and taking appropriate action. The "write_model_template" was then updated to use the new method.
Added a unit test using the "Item" model to verify functionality.
https://umd-dit.atlassian.net/browse/LIBFCREPO-1438