Better handle cancel button internally #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRoachie
force-pushed
the
showCancelWhileEditing
branch
from
ee211f8 to
4b75649
Compare
iRoachie
changed the title
|
Simple markup to test behavior: <SearchBar
showsCancelWhileEditing
ref={ref => (this.searchBar = ref)}
barTintColor={Theme.primary}
tintColor={Theme.secondary}
onChangeText={(text: string) => this.searchChanged(text)}
onSearchButtonPress={() => this.searchBar.blur()}
/>Produces this output:
|
iRoachie
force-pushed
the
showCancelWhileEditing
branch
5 times, most recently
from
7f21022 to
732faf4
Compare
…us for showCancelWhileEditing Rename showCancelWhileEditing to showCancelButtonWhileEditing
iRoachie
force-pushed
the
showCancelWhileEditing
branch
from
732faf4 to
789a8d1
Compare
iRoachie
changed the title
iRoachie
changed the title
iRoachie
added a commit
that referenced
this pull request
Jan 8, 2018
* feat: Handle cancel button behaviour on blur, cancel, search, and focus for showCancelWhileEditing Rename showCancelWhileEditing to showCancelButtonWhileEditing * fix(onCancelButtonPress): Clear text in search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only shows the cancel button when the search bar has focus. No more hacks with setting state on focus needed