Fix podspec to point to correct directory #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try referencing this project's podspec, you get the following error: ``` [!] Failed to load 'ReactNativeSearchBar' podspec: [!] Invalid `ReactNativeSearchBar.podspec` file: No such file or directory @ rb_sysopen - node_modules/react-native-search-bar/ios/package.json. # from node_modules/react-native-search-bar/ios/ReactNativeSearchBar.podspec:2 # ------------------------------------------- # require "json" > package = JSON.parse(File.read(File.join(__dir__, "package.json"))) # # ------------------------------------------- ``` It's trying to load a `package.json` file in the iOS directory, which doesn't exist. Most open-source RN libraries have their podspec in the root folder.
Updating the `source_files` path to reflect the podspec move.
|
Thanks! Forgot this when I moved everything into the iOS folder. |
|
Live in v3.3.1. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try referencing this project's podspec, you get the following error:
It's trying to load a
package.jsonfile in the iOS directory, which doesn't exist. Most open-source RN libraries have their podspec in the root folder [1][2], so I propose to move the podspec and update thesource_filespath accordingly.