-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate create command to standalone package #27
Conversation
🦋 Changeset detectedLatest commit: 62656e3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
package.json
Outdated
@@ -45,6 +45,7 @@ | |||
"compression": "^1.7.5", | |||
"connect-history-api-fallback": "^2.0.0", | |||
"cors": "^2.8.5", | |||
"create-tnf": "^0.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抱歉,可能前面没说清楚。
1、create-tnf 单独成包,不作为主包的依赖
2、主包里删除 create 命令
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就是整个主包的create 命令提出成为单独的包;主包不再提供create相关的命令了是吧;那了解了;明天重新处理下
package.json
Outdated
"@commitlint/cli": "^19.0.3", | ||
"@commitlint/config-conventional": "^19.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不要挪位置。
create-tnf/package.json
Outdated
"main": "dist/index.js", | ||
"types": "dist/types/index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1、应该没有 dist/types/index.d.ts 吧
2、要加个 create-tnf 的 bin
3、templates 目录要挪到 create-tnf 下
记得提交前先执行 pnpm ci 。 |
主要更改:
功能迁移:将 create 命令逻辑从主包中提取到 create-tnf 独立包。
路径调整:在主包中修改了导入路径,使其指向构建后文件的正确位置。
Close #24
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm ci
Changesets
pnpm changeset
and following the prompts. Changesets that add features and fix bugs should all bepatch
before we release0.1.0
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits