Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): specific script type not working for vite mode #10195

Merged
merged 1 commit into from
Jan 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/server/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,14 @@ export async function getMarkup(
props: script,
filters: ['src', 'content'],
});
// allow specific type from config
const isEsmScript = opts.esmScript && !('type' in script);

return script.src
? `<script${opts.esmScript ? ' type="module"' : ''} ${attrs} src="${
? `<script${isEsmScript ? ' type="module"' : ''} ${attrs} src="${
script.src
}"></script>`
: `<script${opts.esmScript ? ' type="module"' : ''} ${attrs}>${
: `<script${isEsmScript ? ' type="module"' : ''} ${attrs}>${
script.content
}</script>`;
}
Expand Down