Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't verify subscription email once more for email users #1574

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jan 8, 2023

Previous behaviour is preserved for query parameters way of requesting the subscription. The new behaviour with the possibility to confirm the email right away without a separate /email/confirm call is enabled only with request params sent in the request body, which was not a thing before 27fc339, which was merged just now and is not part of any tagged version yet.

The backend part of #1174.

@paskal paskal added the backend label Jan 8, 2023
@paskal paskal requested a review from umputun as a code owner January 8, 2023 23:56
Previous behaviour is preserved for query parameters way of requesting
the subscription. The new behaviour with the possibility to confirm
the email right away without a separate /email/confirm call is enabled
only with request params sent in the request body, which was not a thing
before 27fc339, which was merged just now and is not part
of any tagged version yet.
@paskal paskal force-pushed the paskal/easy_subscription branch from 54de41b to 152d80c Compare January 9, 2023 00:01
@umputun umputun merged commit 385ea80 into master Jan 9, 2023
@umputun umputun deleted the paskal/easy_subscription branch January 9, 2023 09:17
@paskal paskal added this to the v1.11.3 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants