Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker images, clarify comments #1778

Merged
merged 1 commit into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM node:16.20.2-alpine AS frontend-deps
FROM --platform=$BUILDPLATFORM node:16.20-alpine AS frontend-deps

ARG SKIP_FRONTEND_TEST
ARG SKIP_FRONTEND_BUILD
Expand Down Expand Up @@ -45,7 +45,7 @@ RUN \
echo 'Skip frontend build'; \
fi

FROM umputun/baseimage:buildgo-v1.12.0 as build-backend
FROM umputun/baseimage:buildgo-v1.13.0 as build-backend

ARG CI
ARG GITHUB_REF
Expand Down Expand Up @@ -81,15 +81,15 @@ RUN \
echo "version=$version" && \
go build -o remark42 -ldflags "-X main.revision=${version} -s -w" ./app

FROM umputun/baseimage:app-v1.12.0
FROM umputun/baseimage:app-v1.13.0

ARG GITHUB_SHA

LABEL org.opencontainers.image.authors="Umputun <umputun@gmail.com>" \
org.opencontainers.image.description="Remark42 comment engine" \
org.opencontainers.image.documentation="https://remark42.com/docs/getting-started/" \
org.opencontainers.image.licenses="MIT" \
org.opencontainers.image.source="https://github.com/umputun/remark42.git" \
org.opencontainers.image.source="https://github.com/umputun/remark42" \
org.opencontainers.image.title="Remark42" \
org.opencontainers.image.url="https://remark42.com/" \
org.opencontainers.image.revision="${GITHUB_SHA}"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.artifacts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ WORKDIR /srv/frontend/apps/remark42/
COPY ./frontend/apps/remark42/ /srv/frontend/apps/remark42/
RUN pnpm build

FROM umputun/baseimage:buildgo-v1.12.0 as build-backend
FROM umputun/baseimage:buildgo-v1.13.0 as build-backend

ARG GITHUB_TOKEN
ARG GITHUB_REF
Expand Down
6 changes: 3 additions & 3 deletions backend/_example/memory_store/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
FROM umputun/baseimage:buildgo-v1.12.0 as build-backend
FROM umputun/baseimage:buildgo-v1.13.0 as build-backend

ADD backend /build/backend
WORKDIR /build/backend/_example/memory_store

RUN go build -o /build/bin/memory_store -ldflags "-X main.revision=0.0.0 -s -w"

FROM umputun/baseimage:app-v1.12.0
FROM umputun/baseimage:app-v1.13.0

ARG GITHUB_SHA

LABEL org.opencontainers.image.authors="Umputun <umputun@gmail.com>" \
org.opencontainers.image.description="Remark42 comment engine example JRPC memory store" \
org.opencontainers.image.documentation="https://github.com/umputun/remark42/tree/master/backend/_example/memory_store" \
org.opencontainers.image.licenses="MIT" \
org.opencontainers.image.source="https://github.com/umputun/remark42.git" \
org.opencontainers.image.source="https://github.com/umputun/remark42" \
org.opencontainers.image.title="Remark42 JRPC example memory store" \
org.opencontainers.image.url="https://remark42.com/" \
org.opencontainers.image.revision="${GITHUB_SHA}"
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile.e2e
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/playwright:v1.40.1-jammy
FROM mcr.microsoft.com/playwright:v1.44-jammy

ENV CI true
WORKDIR /frontend
Expand Down
2 changes: 1 addition & 1 deletion site/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ LABEL org.opencontainers.image.authors="Umputun <umputun@gmail.com>" \
org.opencontainers.image.description="Remark42 site" \
org.opencontainers.image.documentation="https://github.com/umputun/remark42/tree/master/site" \
org.opencontainers.image.licenses="MIT" \
org.opencontainers.image.source="https://github.com/umputun/remark42.git" \
org.opencontainers.image.source="https://github.com/umputun/remark42" \
org.opencontainers.image.title="Remark42 site" \
org.opencontainers.image.url="https://remark42.com/"

Expand Down
Loading