Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new top-level field to playbooks (both full and simplified versions), allowing to set the local shell (i.e.
local_shell=/bin/bash
)This is because there are unpredictable and unexpected results if we run some scripts with local mode on a different host. For example, this simple script works fine with
#/bin/sh
but doesn't work correctly with#/bin/zsh
The change is back compatible, i.e., if
local_shell
is not set, it will follow the old logic (os.Getenv("SHELL")
with failback to/bin/sh
)