Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hostname #185

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Fix missing hostname #185

merged 2 commits into from
Mar 24, 2024

Conversation

umputun
Copy link
Owner

@umputun umputun commented Mar 24, 2024

The hostname was missing if it was set directly without inventory. The lack of a hostname causes an empty $SPOT_REMOTE_NAME value

umputun added 2 commits March 24, 2024 01:35
Lack of populated destination's name prevented expansion of SPOT_HOST_NAME var.
@umputun umputun merged commit b944985 into master Mar 24, 2024
3 checks passed
@umputun umputun deleted the fix-missing-hostname branch March 24, 2024 07:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8407851242

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 84.557%

Files with Coverage Reduction New Missed Lines %
pkg/runner/runner.go 2 89.69%
Totals Coverage Status
Change from base Build 8403989279: -0.04%
Covered Lines: 2683
Relevant Lines: 3173

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants