Fix handling of user set on the task level #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change eliminates setting the default task.User on the config level, and moves this responsibility to the runner. Now the runner explicitly checks the presence of task.User and passes it in. In addition, runTaskOnHost sets the passed user into activeTask (a copy of the task used later on). This was done to be able to know what the actual user is. Currently, the only use is in setting SPOT_REMOTE_USER, however, it can also be used in any place that needs to know the active remote user.
Pull Request Test Coverage Report for Build 8789060733Details
💛 - Coveralls |
Deploying spot-site with
|
| Latest commit: |
ac11d63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d02ffa87.spot-7ki.pages.dev |
| Branch Preview URL: | https://task-user-fix.spot-7ki.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #192
Currently support of user set on the task level is partial and confusing. The user is set on the playbook level, but forced to the top-level (playbook's) user if not defined. This is not a good idea, as this way we can't properly use it because it doesn't handle inventory-level user. In fact, the code didn't even use it to pick the user for remote session, but rather used it for
SPOT_REMOTE_USERresolution.