check on rasters + fix RCM bug #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrouaze
reviewed
Oct 15, 2024
| @@ -103,7 +106,7 @@ def flip_sample_da(self): | |||
| antenna_pointing = self.dt['sourceAttributes/radarParameters'].attrs['antennaPointing'] | |||
| pass_direction = self.dt['sourceAttributes/orbitAndAttitude/orbitInformation'].attrs['passDirection'] | |||
| flipped_cases = [('Left', 'Ascending'), ('Right', 'Descending')] | |||
| samples_depending_ds = ['geolocationGrid', 'lut', 'noise_lut'] | |||
| samples_depending_ds = ['geolocationGrid'] | |||
There was a problem hiding this comment.
Is it the modification tha prevent the bug of flipped RCM images? Is there an issue opened related to this problem?
There was a problem hiding this comment.
No issue, should I create one to explain the problem?
Yes, this is the line that prevent the RCM bug
There was a problem hiding this comment.
note: the variable name samples_depending_ds is not super explicit.
vincelhx
changed the title
|
@vincelhx I doing an infringement to our rules of githuber, I set your PR as "ready for review" and I merged it but it seems that Théo is stuck with his processings without your correction on RCM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.rasters needs to be an instance attr ; not class attr