Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GITLAB_COMMENT_TYPE env variable to use discussions or notes #98

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

QuiiBz
Copy link
Contributor

@QuiiBz QuiiBz commented Mar 17, 2023

This PR adds a new COMMENT_TYPE environment variable, to control the type of comment created when using changesets-gitlab comment:

  • discussion creates a new discussion (thread). This is the default
  • note creates a note (comment)

This is useful when a GitLab repo requires all threads to be resolved before merging an MR. We can instead use this new note COMMENT_TYPE which won't block merging.

@stackblitz
Copy link

stackblitz bot commented Mar 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: f0b4ceb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changesets-gitlab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member

JounQin commented Mar 17, 2023

This is useful when a GitLab repo requires all threads to be resolved before merging an MR.

Just curious, why not just resolve the thread if you want to merge?

@QuiiBz
Copy link
Contributor Author

QuiiBz commented Mar 17, 2023

Just curious, why not just resolve the thread if you want to merge?

It creates an extra step that isn't needed, and makes it impossible to auto-merge MR from bots (e.g renovate).

@JounQin
Copy link
Member

JounQin commented Mar 17, 2023

It creates an extra step that isn't needed, and makes it impossible to auto-merge MR from bots (e.g renovate).

Thanks for explain! I didn't use auto-merge MR from bots in GitLab.

I think this PR is acceptable.

README.md Outdated Show resolved Hide resolved
@JounQin JounQin changed the title feat: add COMMENT_TYPE env variable to use discussions or notes feat: add GITLAB_COMMENT_TYPE env variable to use discussions or notes Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants