Add support for node protocol require/import. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See for instance nodejs/node#38343.
|
PS: A similar addition would be needed for the power-assert babel plugins and presets but I do not know where to start. |
|
@make-github-pseudonymous-again Oh I didn't noticed this significant change. Thanks!! |
|
LGTM 👍 |
|
@make-github-pseudonymous-again v3.1.0 is out. Thank you for your contribution! |
|
@twada Thanks a lot for your rapid action! |
|
@twada Have you worked on power-assert? I can work on it if you want. I would need some pointers though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the right place to implement this feature. I need something like this to continue working since xo v0.40.0 was released. See for instance nodejs/node#38343.