Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the py-tracebacker for mules #2251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable the py-tracebacker for mules #2251

wants to merge 2 commits into from

Conversation

maugt
Copy link

@maugt maugt commented Nov 20, 2020

The current traceback system is great for giving visibility into the callstacks for serving requests, but when you use mules you don't get to see the same data.

This adds a new configuration option, --py-tracebacker-mule, which works the same way as --py-tracebacker. I added a new option because I didn't want to break anyone who was using the old behavior (although an earlier version of this change simply uses the same base path and adds -mule as a suffix between the path and the number). This results in in the same sockets being created as before and you can then read the stacks from them.

This is really useful in my usage, and I hoped others might find it useful enough that it should be a core feature.

@maugt maugt changed the base branch from master to uwsgi-2.0 November 21, 2020 00:35
@maugt maugt changed the base branch from uwsgi-2.0 to master November 21, 2020 00:35
@maugt
Copy link
Author

maugt commented Nov 21, 2020

Hmm guess I merged this into the wrong branch, will resubmit

@maugt maugt closed this Nov 21, 2020
@maugt
Copy link
Author

maugt commented Nov 21, 2020

Actually, I take that back, this does seem to be the right branch, the build is just broken

@maugt maugt reopened this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant