Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parasitic word "Identification" from prop names #48

Closed
VladimirAlexiev opened this issue Feb 1, 2022 · 2 comments · Fixed by #81
Closed

remove parasitic word "Identification" from prop names #48

VladimirAlexiev opened this issue Feb 1, 2022 · 2 comments · Fixed by #81
Labels
NDR This is an issue which needs fixing on the transformation/graph creation semantics This is an issue inherited from the source CCTS model

Comments

@VladimirAlexiev
Copy link

There are 103 props called ...Identification:

PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
select * {
  ?x a rdf:Property
  filter(regex(str(?x),"Identification"))
}

Of them 99 are called "IdentificationId" (stuttering syndrome?)

Rename these 99 props by removing the parasitic word ...Identification.. from ...IdentificationId....

  • Eg uncefact:versionIdentificationId, bICIdentificationId
  • These led to prop duplication, which clearly shows the parasitic nature of the long word

Renaming ...Indicator to is... won't work well:

  • eg transportEquipmentSplitGoodsIndicator
  • cannot be named isTransportEquipmentSplitGoods
  • could
@nissimsan nissimsan added the semantics This is an issue inherited from the source CCTS model label Mar 4, 2022
@nissimsan nissimsan added the NDR This is an issue which needs fixing on the transformation/graph creation label Apr 14, 2022
@nissimsan
Copy link
Contributor

@kshychko, I think this might actually be worthwhile cleaning these IdentificationId out in the code. They sure are ugly.

@nissimsan
Copy link
Contributor

Creditor_ Financial Institution. Hong Kong Bank_ Identification. Identifier

As far as I can tell consistently, Identification is always paired with Identifier. So we could just ignore Identification altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NDR This is an issue which needs fixing on the transformation/graph creation semantics This is an issue inherited from the source CCTS model
Projects
None yet
2 participants