Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop Name Doublons #51

Closed
VladimirAlexiev opened this issue Feb 1, 2022 · 3 comments · Fixed by #90
Closed

Prop Name Doublons #51

VladimirAlexiev opened this issue Feb 1, 2022 · 3 comments · Fixed by #90
Assignees

Comments

@VladimirAlexiev
Copy link

VladimirAlexiev commented Feb 1, 2022

In addition to "IdentificationId" stuttering (#48), there are more insidious dublons in prop names that need fixing

  • duplicated word: formattedFormattedCancellationAnnouncedLaunchDateTime : but see Parasitic Word "Formatted" #52 for a whole family
  • duplicated word: referenceReferenceTypeCode
  • duplicated phrase: documentLineDocumentLineStatusCode
@VladimirAlexiev
Copy link
Author

locationFunctionFunctionTypeCode -> locationFunctionType

@nissimsan
Copy link
Contributor

Discussing on the call how could make an NDR rule to sort these sorts of situations out.

Best option is likely to simply remove duplicate words right next to each other.

@kshychko please run with this.

@kshychko
Copy link
Contributor

The following NDR rules were implemented to produce the suggested changes in this ticket:

  1. When Object Class Term Qualifier with Object Class Term or/and Data Type Qualifier are used to generate a property name they, are checked if the next word/phrase starts with the same character sequence.
  2. Additional final check splits every property name into words and removes the duplicate word next to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants