Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix names/descriptions of "Identification" props #49

Closed
VladimirAlexiev opened this issue Feb 1, 2022 · 1 comment
Closed

fix names/descriptions of "Identification" props #49

VladimirAlexiev opened this issue Feb 1, 2022 · 1 comment
Labels
semantics This is an issue inherited from the source CCTS model

Comments

@VladimirAlexiev
Copy link

Follow-up from #48

Here are the remaining 4 props:

PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
select * {
  ?x a rdf:Property
  filter(regex(str(?x),"Identification"))
  filter(!regex(str(?x),"IdentificationId"))
}

Proposed renaming (...Code can only be a string, not an object!)

  • uncefact:allowanceChargeIdentificationTypeCode "The code specifying the type of this trade allowance charge."
    range UNCL5189Code "Code specifying the identification of an allowance or charge."
    rename to allowanceOrChargeType
  • uncefact:geoCoordinateIdentificationGeographicalCoordinate range GeoCoordinate:
    rename to geoCoordinate
    and fix description not to talk about plurals and identifications!
  • uncefact:natureIdentificationCargo: descr sounds like it's free text "Transport cargo details of the consignment or consignment item sufficient to identify its nature for customs, statistical or transport purposes."
    but in fact it has range uncefact:Cargo,
    so rename to cargo
    • The descr of class Cargo is simply "Goods being transported." with none of that "sufficient to identify its nature" fuzziness?
      Resolve that difference
  • uncefact:uNDGIdentificationCode: "United Nations Dangerous Goods (UNDG) number":
    rename to undgCode
@VladimirAlexiev
Copy link
Author

VladimirAlexiev commented Feb 1, 2022

Another beauty:

  • uKSortCodeIdentificationId "A unique United Kingdom (UK) Sort Code identifier as assigned by the UK Payment Association (APACS) for the financial institution."
    • Rename to ukApacsSortCode or ukApacsId
    • add rdfs:seeAlso link to some info about it

@nissimsan nissimsan added the semantics This is an issue inherited from the source CCTS model label Mar 4, 2022
@nissimsan nissimsan mentioned this issue Apr 14, 2022
@nissimsan nissimsan added NDR This is an issue which needs fixing on the transformation/graph creation semantics This is an issue inherited from the source CCTS model and removed semantics This is an issue inherited from the source CCTS model NDR This is an issue which needs fixing on the transformation/graph creation labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantics This is an issue inherited from the source CCTS model
Projects
None yet
Development

No branches or pull requests

3 participants