Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badger added and working #32

Merged
merged 3 commits into from
Jul 1, 2024
Merged

badger added and working #32

merged 3 commits into from
Jul 1, 2024

Conversation

dpet
Copy link
Collaborator

@dpet dpet commented Jun 19, 2024

No description provided.

@uncomputable
Copy link
Owner

uncomputable commented Jun 20, 2024

Error: Failed to invoke action displaySetContentScale: frame state invalid

Switching to mobile (Firefox) causes an error that seems to disable the ducking animation upon mouse hover. On Chrome, there is no error but the ducking is also disabled.

Made the rive js runtime local so it can work offline
Added error catching to the js functions because if they fail then it stops the rust functions from running
Removed the sleep animation and added a blue lazer animation
Removed duplicate logo svg
@dpet
Copy link
Collaborator Author

dpet commented Jun 20, 2024

I was unable to duplicate the firefox mobile error. In Chrome, when it emulates a mobile device, the cursor does not have a hover state because you can only press or not press on a tablet or phone. Clicking on the screen activates the hover state and pressing somewhere else deactivates it. I added error catching so errors in the js don't stop the subsequent rust functions from running.

run button moved to the top of footer section on mobile
badger blue laser animation removed
Rive library loaded over cdn instead of storing it locally
Copy link
Owner

@uncomputable uncomputable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 977c455

@uncomputable uncomputable merged commit 9450833 into uncomputable:master Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants