Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2256] Resource predicate presentation differs depending on how it is set up #1558

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[UNDERTOW-2256] Resource predicate presentation differs depending on how it is set up #1558

merged 1 commit into from
Jul 29, 2024

Conversation

Dkafetzis
Copy link

@Dkafetzis
Copy link
Author

@fl4via could I get a review on this?

@Dkafetzis
Copy link
Author

@fl4via Could I get a review on this?

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Apr 3, 2024
@baranowb
Copy link
Contributor

baranowb commented Apr 3, 2024

Looks fine.

@baranowb baranowb requested a review from ropalka June 24, 2024 10:57
@baranowb baranowb self-requested a review June 26, 2024 07:35
@baranowb baranowb added next release This PR will be merged before next release or has already been merged (for payload double check) and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Jun 26, 2024
@baranowb baranowb merged commit 1f9490a into undertow-io:main Jul 29, 2024
@fl4via fl4via mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@baranowb baranowb baranowb approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
3 participants
@Dkafetzis @baranowb @ropalka