Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2273] Change ExchangeAttributeParser so it correctly handle… #1575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2273] Change ExchangeAttributeParser so it correctly handle… #1575

wants to merge 1 commit into from

Conversation

xjusko
Copy link
Contributor

@xjusko xjusko commented Apr 5, 2024

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review labels Apr 16, 2024
@baranowb baranowb added the waiting PR update Awaiting PR update(s) from contributor before merging label Jun 24, 2024
baranowb
baranowb requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@baranowb baranowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a simple test case?

ropalka
ropalka requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please provide a simple test case.

@xjusko
Copy link
Contributor Author

xjusko commented Jul 8, 2024

@baranowb @ropalka I added a simple test for parsing. I will edit/add tests with nested attributes once I implement some in future PR.

@baranowb baranowb removed the waiting PR update Awaiting PR update(s) from contributor before merging label Jul 11, 2024
@ropalka ropalka removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@baranowb baranowb baranowb approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases)
Projects
None yet
Milestone
No milestone
3 participants
@xjusko @ropalka @baranowb