-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-1889] switch to mockito #1576
base: main
Are you sure you want to change the base?
Conversation
<groupId>org.mockito</groupId> | ||
<artifactId>mockito-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes no sense - don't add a dependency that is never used. If a subsequent change will require this dependency, the onus will be on them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rhusar - the org.easymock dependency should be removed if it is not used at all.
<groupId>org.mockito</groupId> | ||
<artifactId>mockito-core</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rhusar - the org.easymock dependency should be removed if it is not used at all.
Issue: https://issues.redhat.com/browse/UNDERTOW-1889