Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2462] adds DEFAULT_ALLOW_ENCODED_SLASH #1677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChandanaRao13
Copy link

@ChandanaRao13 ChandanaRao13 commented Oct 4, 2024

This adds a default value for ALLOW_ENCODED_SLASH.
https://issues.redhat.com/browse/UNDERTOW-2462

@ChandanaRao13 ChandanaRao13 changed the title Undertow 2462 [UNDERTOW-2462] adds DEFAULT_ALLOW_ENCODED_SLASH Oct 4, 2024
@ChandanaRao13 ChandanaRao13 marked this pull request as ready for review October 4, 2024 18:53
Copy link
Member

@fl4via fl4via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Please add the issue number to the the commit messages like this [UNDERTOW-2462],and there is a comment that needs to be updated in the Javadoc.

@@ -112,13 +112,18 @@ public class UndertowOptions {
*/
public static final Option<Integer> MAX_COOKIES = Option.simple(UndertowOptions.class, "MAX_COOKIES", Integer.class);

/**
* Default value of {@link #ALLOW_EQUALS_IN_COOKIE_VALUE} option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_ALLOW_ENCODED_SLASH. Please update the comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@fl4via
Copy link
Member

fl4via commented Oct 4, 2024

@ChandanaRao13 to quickly edit the commit messages of the last two commits do
git rebase -i HEAD~2
Then mark both commits with e as in edit and save the editor, just like you do when saving the message of a PR. Just replace the word "pick" by "e". You will see the instructions of what to do in the editor itself . To avoid ruining your branch it is a good idea to first create a backup:
git checkout -b UNDERTOW-2462_backup git checkout UNDERTOW-2462
That way, if you make a mistake when rebasing, you can restore your branch to the previous state at any time:
git reset --hard upstream/main (discards everything in your branch after main) git rebase UNDERTOW-2462_backup (restores your branch to exactly what it was)
Thank you for your commit!

@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting PR update Awaiting PR update(s) from contributor before merging new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) next release This PR will be merged before next release or has already been merged (for payload double check) waiting PR update Awaiting PR update(s) from contributor before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants