Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various naming inconsistencies #74

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Fix various naming inconsistencies #74

merged 3 commits into from
Dec 27, 2024

Conversation

caruccio
Copy link
Contributor

Inconsistent filename

Description

Please include a summary of the change, the motivation, and any additional context that helps others understand your PR.

Linked Issues

If these changes close one or more open issues, please tag them as described here.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@lucasjct
Copy link
Contributor

lucasjct commented Dec 27, 2024

Hi @caruccio
Thank you for your contribution.

I saw that the test don't passed. We need to rename the file of test with the same name of file check.

For example:

File check: M-400_image_tagged_latest.yaml
File test: M-400_image_tagged_latest_test.yaml

You can see the this file test here:
https://github.com/undistro/marvin/tree/main/internal/builtins/general

@lucasjct lucasjct added the enhancement New feature or request label Dec 27, 2024
@caruccio caruccio changed the title Rename M-400_image_tag_latest.yaml to M-400_image_tagged_latest.yaml Fix various naming inconsistencies Dec 27, 2024
@caruccio
Copy link
Contributor Author

Hey @lucasjct. I've submitted more naming changes. Can you please review, and if it's fine squash and rebase?

@caruccio
Copy link
Contributor Author

Forgot one file.

Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caruccio , after run locally this branch and run the test and scan, we can assure everthing is ok.
@matheusfm fyi

@lucasjct lucasjct merged commit f2ee9a6 into main Dec 27, 2024
4 checks passed
@lucasjct lucasjct deleted the inconsistent-filename branch December 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants