Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select all text on focus; fix empty val not restored after reopen #865

Merged

Conversation

nbiton
Copy link
Contributor

@nbiton nbiton commented Aug 23, 2019

Resolves #822 (but in an alternative way)
The entire field's contents are selected when the field is focused, so any character typed would remove the existing text, unless another tap is made on the field to place the caret in a specific location.
Also fixes an issue where the solution/next steps value wouldn't be restored if the value was changed, not saved, and the dialog was reopened.
image

@nbiton nbiton temporarily deployed to unee-t-pr-865 August 23, 2019 16:36 Inactive
@franck-boullier
Copy link
Member

Test done:

On Heroku App
logged in as Nath
case 75479

Expected result:

In the More Information page
See

  • Solution
  • Deadline
  • Next Step
  • Next Step Date

Issue:

Instead of Next Step Date we see Deadline.

image

Edit solution:

Expected result:

  • Solution can be edited PASSED,
  • The text of the solution is highlighted FAILED

Actual result:

The text is NOT highlighted with FF on a DT
image

Edit Deadline

  • Deadline can be edited PASSED

Edit Next Step:

Expected result:

  • Next Step can be edited PASSED
  • The text of the solution is highlighted FAILED

Actual result:

The text is NOT highlighted with FF on a DT
image

Edit Next Step Date:

  • Next Step Date can be edited PASSED
  • Text reads Deadline instead of Next Step Date FAILED
    image

@nbiton
Copy link
Contributor Author

nbiton commented Aug 25, 2019

The text is NOT highlighted with FF on a DT

Fixed in the last commit

Text reads Deadline instead of Next Step Date FAILED

Since this was already introduced in a previously merged PR, and not as a part of this one, I'll issue another PR to fix it.

@franck-boullier franck-boullier merged commit 244a5a4 into unee-t:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the user to delete the next steps and solutions fields in a single tap
2 participants