Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update url given to user after upload #1604

Closed
da1nerd opened this issue Sep 22, 2016 · 6 comments
Closed

update url given to user after upload #1604

da1nerd opened this issue Sep 22, 2016 · 6 comments
Assignees

Comments

@da1nerd
Copy link
Contributor

da1nerd commented Sep 22, 2016

requirements at unfoldingWord-dev/ts-requirements#176

@da1nerd da1nerd self-assigned this Sep 23, 2016
This was referenced Sep 23, 2016
da1nerd added a commit that referenced this issue Sep 23, 2016
@cckozie
Copy link

cckozie commented Sep 27, 2016

Is this issue in translationStudio - 9.0 (141) #18?
My testing shows 2 problems.
1-- The previous success screen with the link to the project has been changed as follows:
Was...
screenshot_2016-09-28-06-37-14

Now is...
screenshot_2016-09-27-17-36-11

2-- When the "VIEW ONLINE" link is clicked, it takes me to the old git.door43.org/... page.

@da1nerd
Copy link
Contributor Author

da1nerd commented Sep 27, 2016

@cckozie the new url is currently a redirect. This is the expected behavior.
As for the change from a clickable link to a button. This is better design practice for the Android os.

@da1nerd
Copy link
Contributor Author

da1nerd commented Oct 14, 2016

@cckozie is this still failed?

@cckozie
Copy link

cckozie commented Jan 25, 2017

This is what is displayed when the user clicks DETAILS on the Success dialog.
@klappy Is this what we want to display for the repo URL?
screenshot_2017-01-25-09-20-02

@klappy
Copy link

klappy commented Feb 9, 2017

I like the link that explicitly says, "view online"
According to Jesse in some issue along the way maybe in the requirements, there was something to use and show only the one link, https://door43.org/u/klappy/en-x-demo1_jas_text_reg which will redirect the users to the appropriate place, currently it redirects to the repo on the gogs server, later it will redirect to the live site.

Let's make it look closer to desktop by removing the git url and showing the user friendly url:

screen shot 2017-02-08 at 7 03 39 pm

@da1nerd
Copy link
Contributor Author

da1nerd commented Feb 9, 2017

I updated the dialog to look like desktop. However, I left the details button alone. That's simply there to provide context to anyone trying to debug issues. If you want to change that then we may as well remove it since it'll lose it's purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants