Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 7102/Change bible priority order when showing GL quote #129

Merged
merged 5 commits into from
Oct 7, 2020

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Oct 6, 2020

Describe what your pull request addresses (Please include relevant issue numbers):

  • adds preference to getting GL quotes from bible listed in relation in tHelps manifest
  • adds preference to glt for GL quotes if alignment not found in bibles in tHelps manifest

Please include detailed Test instructions for your pull request:

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #129 into release-v3.0.1 will increase coverage by 1.62%.
The diff coverage is 93.75%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v3.0.1     #129      +/-   ##
==================================================
+ Coverage           23.49%   25.11%   +1.62%     
==================================================
  Files                  53       53              
  Lines                2524     2548      +24     
  Branches              471      479       +8     
==================================================
+ Hits                  593      640      +47     
+ Misses               1572     1556      -16     
+ Partials              359      352       -7     
Impacted Files Coverage Δ
src/selectors/index.js 62.92% <ø> (+1.63%) ⬆️
src/helpers/gatewayLanguageHelpers.js 90.32% <92.85%> (+70.32%) ⬆️
src/helpers/resourcesHelpers.js 27.50% <93.33%> (+27.50%) ⬆️
src/Container.js 84.21% <100.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc303c...9cd4695. Read the comment docs.

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review October 6, 2020 20:58
@PhotoNomad0 PhotoNomad0 changed the title Feature 7102/change gl order Feature 7102/Change bible priority order when showing GL quote Oct 6, 2020
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richmahn richmahn merged commit 5ddc778 into release-v3.0.1 Oct 7, 2020
@PhotoNomad0 PhotoNomad0 deleted the feature-mcleanb-7102/changeGlOrder branch October 10, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants