Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks to 'View on Door43' button #199

Merged
merged 3 commits into from
Jun 22, 2017

Conversation

ethantkoenig
Copy link
Contributor

@ethantkoenig ethantkoenig commented Jun 17, 2017

The inconsistency of having a shadowed, unaligned "View on Door43" button has been bothering me for a while, so I decided to fix it. I also added an icon for consistency with the Watch/Star/Fork buttons; if you think a different icon would be more appropriate, Iet me know.

I took the opportunity to clean-up some inline css, and make our template/repo/header.tmpl more in-sync with upstream's, to mitigate future merge conflicts. I also introduced public/less/_unfoldingWord.less, where we can keep styling changes specific to our fork.

Before:
image

After:
image

@richmahn
Copy link
Member

The shadowed button was actually what the design called for. @jag3773 should verify this change.

@jag3773
Copy link
Contributor

jag3773 commented Jun 22, 2017

@ethantkoenig Let's update this so that the text of the button is "See on Door43" and then move the Door43 icon to the left where the fa book icon currently is.

@ethantkoenig
Copy link
Contributor Author

@jag3773 Done (see updated screenshot in description). Also added a locale for "See on Door43"

@jag3773
Copy link
Contributor

jag3773 commented Jun 22, 2017

@ethantkoenig Looks great, but there appears to be a minor vertical alignment issue inside the button between the text and the icon. Would shrinking the Door43 icon just a bit fix that?

@ethantkoenig
Copy link
Contributor Author

@jag3773 Done. I couldn't find a super clean way to do it (typically I would use flexbox for vertical alignment, but that caused the button's text to be misaligned with the other buttons' text), so I resorted to fiddling with the image margins.

@jag3773 jag3773 merged commit 0d0af03 into unfoldingWord:develop Jun 22, 2017
@ethantkoenig ethantkoenig deleted the ufw/template branch June 25, 2017 02:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants