tW Tool Rewrite with new architecture

[benjore]

No description provided.

[RoyalSix]

• First merging Joels PR (After reviewing)
  Support for wordAlignment Rewrite #4489
  After this wordAlignment will be working and the new tc-tool will be in the core.

• Then we need to review and merge all the PR's for the tc-ui-toolkit and change the package.json in tW to actually have the module installed https://github.com/translationCoreApps/translationWords/blob/658ea4eec6bd92d61d3b74cbc39cbe6c75552be9/package.json#L67

• Then we will need to remove all the old code from tW that is n already coming from the ui-toolkit.

• Then we will need to incorporate the changes Joel made in order to receive the correct data for tW to work again (i.e. wordAlignmentReducer from the API of tc-tool)

• Then we will need to either A. Have the strings in the ui-toolkit (And do it the right way later), or B. Expose the strings from the tool to the toolkit in each component.

• Then we can make a final PR to translationCore (Some things from the original PR in 4492 may not be needed after incorporating Joels changes, forsure somethings will though such as removing the GroupMenu ) and translationWords repos and everything should be working.

[cckozie]

0.10.0 (45ccd50)
There are a number of problems with the new tW implementation:

1. The Menu/Filter bar at the top of the group menu now scrolls off the screen when the group menu is scrolled down.
   
2. The blue used to signify percentage complete is now much darker making it hard to distinguish from the black background.
   new:
   
   old:
   
3. The thelps panel no longer is automatically displayed when the tool is opened.
4. [Moved to The 'See more' link is now visible in black text when the thelps panel is open #4590] The 'See more' link is now visible in black text when the thelps panel is open
   
5. Nothing appears to be localized except the words 'Home' and 'Actions' on the menu bar
6. The Bookmark switch is no longer left aligned on the form
7. When the text in the check pane is expanded, the book name appears above the close 'X' rather than in the center of the title bar.
   
8. When the tHelps pane is expanded, the 'C' on the close button is not capitalized
9. When the tHelps pane is expanded, the wrong content is sometimes displayed. To replicate:
   a. Open a Titus project in tW
   b. Open the tHelps pane
   c. Click on 'Christ, Messiah' in the group menu
   d. Expand the tHelps pane
   e. Click on the '(See also: How to Translate Names)' link
   f. Click the Close button
   g. Click on 'faith' in the group menu
   h. Expand the tHelps pane
   Notice that the article displayed is still How to Translate Names
10. There is no header on the Target Lane card in the expanded scripture pane (image below)
11. [Moved to In the expanded scripture pane, the background color of spaces in even numbered verses is white on all translations except the target language (image below) #4593] In the expanded scripture pane, the background color of spaces in even numbered verses is white on all translations except the target language (image below)
12. [Moved to In the expanded scripture pane, the height of the header row is much greater than it needs to be #4592] In the expanded scripture pane, the height of the header row is much greater than it needs to be
    

I have not finished testing the refactored tW tool, but am stopping here until Monday.

[RoyalSix]

New Tasks

• The Menu/Filter bar at the top of the group menu now scrolls off the screen when the group menu is scrolled down.
• The blue used to signify percentage complete is now much darker making it hard to distinguish from the black background.
  new
• The thelps panel no longer is automatically displayed when the tool is opened.
• Fix tW Localization
• The Bookmark switch is no longer left aligned on the form
• When the text in the check pane is expanded, the book name appears above the close 'X' rather than in the center of the title bar.
• When the tHelps pane is expanded, the 'C' on the close button is not capitalized
• When the tHelps pane is expanded, the wrong content is sometimes displayed.
• There is no header on the Target Lane card in the expanded scripture pane
• Scripture pane verse editor not being reset for new check

[RoyalSix]

For #10 I am not able to replicate, can you share the project you used? @cckozie
@RoyalSix See en_ult_tit_text.zip It was imported from USFM.

[RoyalSix]

Ok @cckozie I investigated that issue and it is unrelated to the changes made here. That is project problem.
That same thing happens if you use that project in 0.10.0 (before the refactor)
@RoyalSix Unfortunately it's not a problem with the project. Any project imported from USFM has the same issue. I'll create a new issue for it.

[richmahn]

@RoyalSix Getting this big white 0 to the right of the funnel in the Menu header:

[richmahn]

@RoyalSix No links work in the tHelps when it is just a sidebar, they do work when tHelps is expanded to a modal.

[cckozie]

0.10.0 (ed1e141)

1. When a project is loaded in tW, it should open in 'Select' mode. The user should not have to click the Select button before making a selection.
   Open in 'Select' Mode By Default translationWords#136
2. When in Select mode, the Cancel, Clear, and Save buttons should be right aligned. The Save button should be located in the same place as the Save & Continue button so the user doesn't need to move the cursor between clicks of those buttons.
   Verse Check Buttons Alignment Fix tc-ui-toolkit#42
3. The Clear Selection button should be enabled as soon as any selection has been made rather than only after the selection has been Saved.
   Cancel Button Enabled After Selection tc-ui-toolkit#43
4. When in Edit or Comment mode, the Cancel and Save buttons should be right aligned.
   Verse Check Buttons Alignment Fix tc-ui-toolkit#42
   NOTE: I am still testing this issue, so there may be more items added here.

[cckozie]

All issues appear to have been fixed in 0.10.0 (2270c71), other than #10 noted above which has been moved to #4394.