Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates From QA Fail 4318 #4617

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Updates From QA Fail 4318 #4617

merged 4 commits into from
Jun 15, 2018

Conversation

RoyalSix
Copy link

@RoyalSix RoyalSix commented Jun 14, 2018

Describe what your pull request addresses (Please include relevant issue numbers):

You will need the checkout feature-jay-4318 on translationWords repo

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

@RoyalSix RoyalSix requested a review from mannycolon June 14, 2018 13:26
@dsm-git
Copy link

dsm-git commented Jun 14, 2018

Linux build 0.10.0 (ae5f020) is ready for download.
macOS build 0.10.0 (ae5f020) is ready for download.
Windows x64 build 0.10.0 (ae5f020) is ready for download.
Windows x32 build 0.10.0 (ae5f020) is ready for download.

@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #4617 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4617      +/-   ##
===========================================
+ Coverage    57.56%   57.59%   +0.03%     
===========================================
  Files          256      256              
  Lines         7086     7153      +67     
  Branches      1179     1206      +27     
===========================================
+ Hits          4079     4120      +41     
- Misses        2607     2625      +18     
- Partials       400      408       +8
Impacted Files Coverage Δ
src/js/helpers/invalidatedCheckHelpers.js 23.07% <0%> (-1.49%) ⬇️
src/js/actions/VerseEditActions.js 13.95% <0%> (-0.34%) ⬇️
src/js/actions/SelectionsActions.js 75.71% <0%> (+4.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f63af...45adf57. Read the comment docs.

@dsm-git
Copy link

dsm-git commented Jun 14, 2018

Linux build 0.10.0 (02cab55) is ready for download.
macOS build 0.10.0 (02cab55) is ready for download.
Windows x64 build 0.10.0 (02cab55) is ready for download.
Windows x32 build 0.10.0 (02cab55) is ready for download.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jun 14, 2018

@RoyalSix - still seeing QA issue:

The thelps panel no longer is automatically displayed when the tool is opened.

had wrong tw branch.

@RoyalSix
Copy link
Author

RoyalSix commented Jun 14, 2018

@PhotoNomad0 Do you see blue progress bars for the Group Menu?

@PhotoNomad0
Copy link
Contributor

@RoyalSix - sorry I didn't notice problem checking out tw - you have a typo in the branch name. problem went away.

@RoyalSix
Copy link
Author

Oh no! bitmoji

@PhotoNomad0
Copy link
Contributor

@RoyalSix - still seeing QA fail number 7 : When the text in the check pane is expanded, the book name appears above the close ‘X’ rather than in the center of the title bar.

@PhotoNomad0
Copy link
Contributor

Reviewed 2 of 2 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mannycolon)


Comments from Reviewable

@PhotoNomad0
Copy link
Contributor

:lgtm:


Review status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mannycolon)


Comments from Reviewable

@dsm-git
Copy link

dsm-git commented Jun 14, 2018

Linux build 0.10.0 (81adbec) is ready for download.
macOS build 0.10.0 (81adbec) is ready for download.
Windows x64 build 0.10.0 (81adbec) is ready for download.
Windows x32 build 0.10.0 (81adbec) is ready for download.

@richmahn
Copy link
Member

Ah, the branch typo name was talked about a few hours ago! Wish I had seen that...threw me off.


Reviewed 2 of 2 files at r3.
Review status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mannycolon)


Comments from Reviewable

@dsm-git
Copy link

dsm-git commented Jun 14, 2018

Linux build 0.10.0 (45adf57) is ready for download.
macOS build 0.10.0 (45adf57) is ready for download.
Windows x64 build 0.10.0 (45adf57) is ready for download.
Windows x32 build 0.10.0 (45adf57) is ready for download.

@PhotoNomad0
Copy link
Contributor

Reviewed 2 of 2 files at r3, 2 of 2 files at r4.
Review status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mannycolon)


Comments from Reviewable

@PhotoNomad0
Copy link
Contributor

@RoyalSix - I checked again with 0.9.2, but I still see the issue in tw that 0 is next to filter icon when minimized.

@PhotoNomad0
Copy link
Contributor

@RoyalSix - never-mind, the concourse build is working.

@PhotoNomad0
Copy link
Contributor

:lgtm:


Review status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mannycolon)


Comments from Reviewable

@PhotoNomad0 PhotoNomad0 merged commit 6f4b7f2 into develop Jun 15, 2018
@PhotoNomad0 PhotoNomad0 deleted the feauture-jay-4318 branch June 15, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants