Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest resources from Door43-Catalog broken for en #7588

Closed
PhotoNomad0 opened this issue Aug 27, 2024 · 24 comments
Closed

Get latest resources from Door43-Catalog broken for en #7588

PhotoNomad0 opened this issue Aug 27, 2024 · 24 comments
Assignees

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Aug 27, 2024

Story Explanation

User Story

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@PhotoNomad0 PhotoNomad0 self-assigned this Aug 27, 2024
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Aug 27, 2024

Fix is in release-v3.6.6

Not ready yet.

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 4, 2024

To test, start tcore. After it opens click get started. delete the Door43-Catalog English resources from the translationCore/resources/en folder: delete these folders~/translationCore/resources/en/bibles/ult, ~/translationCore/resources/en/bibles/ust, ~/translationCore/resources/en/translationHelps. "Now do actions/check for content update". Under en, should see the Door43-Catalog content listed:

Screenshot 2024-09-04 at 6 32 10 AM

The fix is if the query returns the master branch as the latest, we look in the source repo in unfoldingWord org to get the latest released version number.

@PhotoNomad0
Copy link
Contributor Author

Note:

still not right, trying again...

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 5, 2024

@elsylambert Latest fix is in translationCore release-3.6.6 (898ab1e) see testing notes above ^^^

Also need a way to test loading of missing original language version dependencies.

Also make sure you can open psalms projects in checking tool with en Door43-Catalog selected.

@elsylambert
Copy link

elsylambert commented Sep 9, 2024

@PhotoNomad0 Testing in translationCore 3.6.6 (d22e4d4). The content updater does not show Door43 Catalog resources, Nor the unfoldingWord org resources.
Screenshot 2024-09-09 at 2 17 04 PM
But the resources folder contains the ULT and UST and also translationHelps folder.
Screenshot 2024-09-09 at 2 17 57 PM

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 10, 2024

@elsylambert Are you sure you deleted the folders after you started tCore? If you delete them before you start tCore, they will be automatically recreated on startup. And the latest versions are already bundled in tCore.

@elsylambert
Copy link

@PhotoNomad0 Thanks for clarifying that. Yes, I am able to see the resources in the content updater, when I delete the folders after restarting tC. So Technically, since en resources from D43 catalog and uW org are bundled with tC, they are available when tC is started.

@elsylambert
Copy link

Testing #7121 for this change

@elsylambert
Copy link

I deleted the contents of el-x-koine under resources folder after restarting tC and tried to open a NT project and got the following warning.
Screenshot 2024-09-10 at 9 42 01 AM
This works as expected. I did the same for two different projects that used two different versions and both the version got downloaded in the ugnt folder.
Screenshot 2024-09-10 at 9 42 21 AM

Again, these folders are bundled when tC is restarted so not getting the prompt untill I delete the contents of the ugnt folder.

@elsylambert
Copy link

Testing with Arabic GL. I deleted Ar resources from the Resource folder and tried to download from the content updator and it showed failed.
Screenshot 2024-09-13 at 11 00 43 AM

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 14, 2024

Testing with Arabic GL. I deleted Ar resources from the Resource folder and tried to download from the content updator and it showed failed. Screenshot 2024-09-13 at 11 00 43 AM

Very interesting - it is trying to download from BSOJ org. Good catch. I'm guessing that you selected ar resources from BSOJ?

@PhotoNomad0
Copy link
Contributor Author

@elsylambert I see from the console log that this failure came after you opened an Arabic project. I presume you were prompted to download the correct original language resource, and that is where it failed?

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 14, 2024

@elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language.

Could you give more detail on how to reproduce this?

And maybe the console log file.

@elsylambert
Copy link

elsylambert commented Sep 14, 2024 via email

@PhotoNomad0
Copy link
Contributor Author

Are you downloading the BSOJ avd resources? I was downloading the Arabic bible resources.

On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean @.> wrote: @elsylambert https://github.com/elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language. Could you give more detail on how to reproduce this? — Reply to this email directly, view it on GitHub <#7588 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE . You are receiving this because you were mentioned.Message ID: @.>

I tried three different ways - all ar resources, BSOJ resources and finally I just tried the AVD. Here are the options I see:

Screenshot 2024-09-14 at 9 36 07 AM

But not reproducing the problem.

@elsylambert
Copy link

elsylambert commented Sep 14, 2024 via email

@PhotoNomad0
Copy link
Contributor Author

@elsylambert Maybe something specific to that project. Where can I get it?

@PhotoNomad0
Copy link
Contributor Author

Testing with translationCore 3.6.6 (d22e4d4)

@elsylambert
Copy link

Arabic resources on my local: ar.zip
Project:
ar_test_phm_book.zip
Log file: Fri Sep 13 2024.log.zip

@PhotoNomad0
Copy link
Contributor Author

Arabic resources on my local: ar.zip Project: ar_test_phm_book.zip Log file: Fri Sep 13 2024.log.zip

Thanks Elsy - the log file helped me find the logic error that it was trying to download the original language from the BSOJ org.

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Sep 16, 2024

@elsylambert Thanks for the log file - it helped identify the problem. It looks like the project had BSOJ/ar selected as the GL for the wordAlignment tool, so when the project was opened it was looking to download the ugnt from the same owner. I found the logic error and made a fix in the latest release build. It should fix the latest problem.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert Looks like I'll have to try again, since that fix uncovered another bug.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert After looking into it further, I only saw a crash because I had deleted all the ugnt versions while app was open - not a typical user scenario. So when you get a chance, go ahead and test the latest release build (635b02f) to see if it works for you.

@elsylambert
Copy link

Verified in translationCore 3.6.6 (635b02f). Not seeing error with Arabic GL resources download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants