-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get latest resources from Door43-Catalog broken for en #7588
Comments
Not ready yet. |
Note: still not right, trying again... |
@elsylambert Latest fix is in translationCore release-3.6.6 (898ab1e) see testing notes above ^^^ Also need a way to test loading of missing original language version dependencies. Also make sure you can open psalms projects in checking tool with en Door43-Catalog selected. |
@PhotoNomad0 Testing in translationCore 3.6.6 (d22e4d4). The content updater does not show Door43 Catalog resources, Nor the unfoldingWord org resources. |
@elsylambert Are you sure you deleted the folders after you started tCore? If you delete them before you start tCore, they will be automatically recreated on startup. And the latest versions are already bundled in tCore. |
@PhotoNomad0 Thanks for clarifying that. Yes, I am able to see the resources in the content updater, when I delete the folders after restarting tC. So Technically, since en resources from D43 catalog and uW org are bundled with tC, they are available when tC is started. |
Testing #7121 for this change |
@elsylambert I see from the console log that this failure came after you opened an Arabic project. I presume you were prompted to download the correct original language resource, and that is where it failed? |
@elsylambert I tried deleting the ugnt, and then opening an ar project, but it didn't fail for me when it downloaded the original language. Could you give more detail on how to reproduce this? And maybe the console log file. |
Are you downloading the BSOJ avd resources? I was downloading the Arabic
bible resources.
…On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean ***@***.***> wrote:
@elsylambert <https://github.com/elsylambert> I tried deleting the ugnt,
and then opening an ar project, but it didn't fail for me when it
downloaded the original language.
Could you give more detail on how to reproduce this?
—
Reply to this email directly, view it on GitHub
<#7588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I tried three different ways - all ar resources, BSOJ resources and finally I just tried the AVD. Here are the options I see: But not reproducing the problem. |
Thanks Bruce, I’m away from my computer now. I will try to replicate again
and send my log file as well.
On Sat, Sep 14, 2024 at 9:41 AM Bruce McLean ***@***.***>
wrote:
… Are you downloading the BSOJ avd resources? I was downloading the Arabic
bible resources.
… <#m_-5489818895582511330_>
On Sat, Sep 14, 2024 at 8:35 AM Bruce McLean *@*.*> wrote: @elsylambert
<https://github.com/elsylambert> https://github.com/elsylambert
<https://github.com/elsylambert> I tried deleting the ugnt, and then
opening an ar project, but it didn't fail for me when it downloaded the
original language. Could you give more detail on how to reproduce this? —
Reply to this email directly, view it on GitHub <#7588 (comment)
<#7588 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE
<https://github.com/notifications/unsubscribe-auth/AMLH7ZGTCB6POY6FBTGOUCLZWQURJAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE3TKNZTGE>
. You are receiving this because you were mentioned.Message ID: @.*>
I tried three different ways - all ar resources, BSOJ resources and
finally I just tried the AVD. Here are the options I see:
Screenshot.2024-09-14.at.9.36.07.AM.png (view on web)
<https://github.com/user-attachments/assets/c644924b-52cd-4aab-a953-bd788c1cb536>
But not reproducing the problem.
—
Reply to this email directly, view it on GitHub
<#7588 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMLH7ZGBL6BP3QFINNJWTNDZWQ4HRAVCNFSM6AAAAABNGGCGLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE4TKNZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@elsylambert Maybe something specific to that project. Where can I get it? |
Testing with translationCore 3.6.6 (d22e4d4) |
Arabic resources on my local: ar.zip |
Thanks Elsy - the log file helped me find the logic error that it was trying to download the original language from the BSOJ org. |
@elsylambert Thanks for the log file - it helped identify the problem. It looks like the project had BSOJ/ar selected as the GL for the wordAlignment tool, so when the project was opened it was looking to download the ugnt from the same owner. I found the logic error and made a fix in the latest release build. It should fix the latest problem. |
@elsylambert Looks like I'll have to try again, since that fix uncovered another bug. |
@elsylambert After looking into it further, I only saw a crash because I had deleted all the ugnt versions while app was open - not a typical user scenario. So when you get a chance, go ahead and test the latest release build (635b02f) to see if it works for you. |
Verified in translationCore 3.6.6 (635b02f). Not seeing error with Arabic GL resources download. |
Story Explanation
User Story
Definition of Done
Additional Context
Mockups
The text was updated successfully, but these errors were encountered: