Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/Fix white space in USFM export #7183

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Nov 16, 2021

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

  • test with build below
  • start with this project: https://git.door43.org/lrsallee/en_ult_1pe_book
  • note percent complete on alignments (I see 99%) Fix the invalidated verse so it gets to 100%
  • do export of Project to usfm and include alignment data
  • open the USFM file in a text editor and should see as below. Mark sure there is no space after the \p token before a verse marker. Also check that \zaln-s and \w tokens do not have a space between the | and the first attribute.

Screen Shot 2021-11-16 at 1 35 06 PM copy

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

@PhotoNomad0 PhotoNomad0 changed the title update usfm-js WIP: BugFix/Fix white space in USFM export Nov 16, 2021
@PhotoNomad0 PhotoNomad0 changed the title WIP: BugFix/Fix white space in USFM export BugFix/Fix white space in USFM export Nov 16, 2021
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 16, 2021 20:09
Copy link
Contributor

@mannycolon mannycolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mannycolon mannycolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

Copy link
Contributor

@mannycolon mannycolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@mannycolon mannycolon merged commit c8c2941 into release-v3.0.2 Nov 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix-joel-7164 branch November 16, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants