Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature crowdin updates #7428

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Feature crowdin updates #7428

merged 2 commits into from
Sep 22, 2022

Conversation

PhotoNomad0
Copy link
Contributor

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review September 22, 2022 14:13
@PhotoNomad0 PhotoNomad0 merged commit 146a9f1 into develop Sep 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature-crowdinUpdates branch September 22, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant