-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature mcleanb 3086/show invalidated on verseCheck #125
Feature mcleanb 3086/show invalidated on verseCheck #125
Conversation
…cleanb-3086/ShowInvalidatedSelection.2 # Conflicts: # package-lock.json # package.json # src/Container.js
…Apps/translationWords_Check_plugin into feature-jay-4318 # Conflicts: # src/Container.js
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
+ Coverage 44.07% 44.6% +0.52%
=========================================
Files 13 13
Lines 422 426 +4
Branches 84 86 +2
=========================================
+ Hits 186 190 +4
Misses 193 193
Partials 43 43
Continue to review full report at Codecov.
|
…Apps/translationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2 # Conflicts: # __tests__/Container.test.js # package-lock.json # package.json
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2 # Conflicts: # package.json
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2 # Conflicts: # package.json
Reviewed 1 of 6 files at r1, 1 of 10 files at r2, 2 of 5 files at r3. package.json, line 70 at r3 (raw file):
You're using 0.8.0 in the core, is this ok? Comments from Reviewable |
Unit tests are failing |
@PhotoNomad0 These steps may be helpful for testing |
Reviewed 2 of 2 files at r4. Comments from Reviewable |
Review status: all files reviewed, 1 unresolved discussion (waiting on @mannycolon) package.json, line 70 at r3 (raw file): Previously, mannycolon (Manny Colon) wrote…
Done. Changed for testing branch. Comments from Reviewable |
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2 # Conflicts: # package-lock.json # package.json
Reviewed 1 of 3 files at r5. Comments from Reviewable |
Reviewed 1 of 6 files at r1, 1 of 10 files at r2, 1 of 5 files at r3, 2 of 3 files at r5. Comments from Reviewable |
Describe what your pull request addresses (Please include relevant issue numbers):
Testing
On local testing, verseCheck with invalidated should look like example in unfoldingWord/translationCore#3086, except with dark background.
Standard Test Instructions for PR Review Process:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)