Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature mcleanb 3086/show invalidated on verseCheck #125

Merged
merged 14 commits into from
Jun 17, 2018

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented May 30, 2018

Describe what your pull request addresses (Please include relevant issue numbers):

  • on verse edit, sets invalidation flag on any selections that are not longer valid in verse.
  • on new selection, clears the invalidation flag for that selection
  • on tw startup, verify all selections to make sure they are still valid.

Testing

  • for local testing use current develop branch of tC

On local testing, verseCheck with invalidated should look like example in unfoldingWord/translationCore#3086, except with dark background.

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

RoyalSix and others added 4 commits May 21, 2018 01:00
…cleanb-3086/ShowInvalidatedSelection.2

# Conflicts:
#	package-lock.json
#	package.json
#	src/Container.js
@PhotoNomad0 PhotoNomad0 self-assigned this May 30, 2018
@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #125 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #125      +/-   ##
=========================================
+ Coverage   44.07%   44.6%   +0.52%     
=========================================
  Files          13      13              
  Lines         422     426       +4     
  Branches       84      86       +2     
=========================================
+ Hits          186     190       +4     
  Misses        193     193              
  Partials       43      43
Impacted Files Coverage Δ
src/containers/VerseCheckContainer.js 34.78% <100%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c153b...8331f2f. Read the comment docs.

…Apps/translationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2

# Conflicts:
#	__tests__/Container.test.js
#	package-lock.json
#	package.json
@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature mcleanb 3086/show invalidated on verseCheck Feature mcleanb 3086/show invalidated on verseCheck Jun 11, 2018
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2

# Conflicts:
#	package.json
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2

# Conflicts:
#	package.json
@mannycolon
Copy link
Contributor

Reviewed 1 of 6 files at r1, 1 of 10 files at r2, 2 of 5 files at r3.
Review status: all files reviewed, 1 unresolved discussion (waiting on @PhotoNomad0)


package.json, line 70 at r3 (raw file):

    "redux-thunk": "^2.3.0",
    "tc-tool": "^1.5.0",
    "tc-ui-toolkit": "^0.7.9",

You're using 0.8.0 in the core, is this ok?


Comments from Reviewable

@mannycolon
Copy link
Contributor

Unit tests are failing

@mannycolon
Copy link
Contributor

mannycolon commented Jun 12, 2018

@PhotoNomad0 These steps may be helpful for testing
unfoldingWord/tc-ui-toolkit@c44913e

@PhotoNomad0 PhotoNomad0 changed the title Feature mcleanb 3086/show invalidated on verseCheck WIP: Feature mcleanb 3086/show invalidated on verseCheck Jun 12, 2018
@mannycolon
Copy link
Contributor

Reviewed 2 of 2 files at r4.
Review status: all files reviewed, 1 unresolved discussion (waiting on @PhotoNomad0)


Comments from Reviewable

@PhotoNomad0
Copy link
Contributor Author

Review status: all files reviewed, 1 unresolved discussion (waiting on @mannycolon)


package.json, line 70 at r3 (raw file):

Previously, mannycolon (Manny Colon) wrote…

You're using 0.8.0 in the core, is this ok?

Done. Changed for testing branch.


Comments from Reviewable

@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature mcleanb 3086/show invalidated on verseCheck Feature mcleanb 3086/show invalidated on verseCheck Jun 13, 2018
@PhotoNomad0 PhotoNomad0 changed the title Feature mcleanb 3086/show invalidated on verseCheck WIP: Feature mcleanb 3086/show invalidated on verseCheck Jun 13, 2018
@PhotoNomad0 PhotoNomad0 changed the title WIP: Feature mcleanb 3086/show invalidated on verseCheck Feature mcleanb 3086/show invalidated on verseCheck Jun 13, 2018
…lationWords_Check_plugin into feature-mcleanb-3086/ShowInvalidatedSelection.2

# Conflicts:
#	package-lock.json
#	package.json
@PhotoNomad0
Copy link
Contributor Author

Reviewed 1 of 3 files at r5.
Review status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @mannycolon and @PhotoNomad0)


Comments from Reviewable

@PhotoNomad0 PhotoNomad0 requested a review from RoyalSix June 17, 2018 00:20
@RoyalSix
Copy link

Reviewed 1 of 6 files at r1, 1 of 10 files at r2, 1 of 5 files at r3, 2 of 3 files at r5.
Review status: all files reviewed, 1 unresolved discussion (waiting on @mannycolon)


Comments from Reviewable

@RoyalSix RoyalSix merged commit 657f24d into master Jun 17, 2018
@richmahn richmahn deleted the feature-mcleanb-3086/ShowInvalidatedSelection.2 branch August 2, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants