Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support reference notices for TN intro fields #110

Open
RobH123 opened this issue Dec 22, 2020 · 1 comment
Open

Remove support reference notices for TN intro fields #110

RobH123 opened this issue Dec 22, 2020 · 1 comment
Assignees
@RobH123

Comments

@RobH123
Copy link
Contributor

RobH123 commented Dec 22, 2020 •
edited
Loading

TN checks ensure that the TW link from OccurrenceNote or Annotation is a valid Just-In-Time (JIT) training article, and that it also occurs in the SupportReference field.

However, it seems that intro fields (as distinct from C:V fields) can have several links and not necessarily limited to the JIT articles. These (priority 786) false alarms should be removed.
@RobH123 RobH123 self-assigned this Dec 22, 2020
@RobH123
Copy link
Contributor Author

RobH123 commented Dec 23, 2020 •
edited
Loading

This should have been fixed a couple of months ago: https://github.com/unfoldingWord/uw-content-validation/blame/master/src/core/tn-table-row-check.js#L501

Need to check what version of this package is being run in tC Create.

RobH123 added a commit that referenced this issue Dec 23, 2020
@RobH123
Moving notice disabling into core for #110
dff6689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobH123 RobH123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RobH123