Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkTN_TSVDataRow() does not validate tA links #37

Closed
PhotoNomad0 opened this issue Sep 17, 2020 · 0 comments · Fixed by #59
Closed

checkTN_TSVDataRow() does not validate tA links #37

PhotoNomad0 opened this issue Sep 17, 2020 · 0 comments · Fixed by #59
Assignees
Labels
bug Something isn't working

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Sep 17, 2020

checkTN_TSVDataRow() does not give an error on invalid tA links. Example that should return error:

GEN\t1\t6\turb3\tfigs-imperative\t\t0\tLet there be an expanse…let it divide\tThese are commands. By commanding that the expanse should exist and that it divide the waters, God made it exist and divide the waters. (See: [[rc://en/ta/man/figs-imperative]])

Another example that should return an error for doublet link:

RUT\t2\t12\tgnn5\tfigs-parallelism\tוּ⁠תְהִ֨י מַשְׂכֻּרְתֵּ֜⁠ךְ שְׁלֵמָ֗ה מֵ⁠עִ֤ם יְהוָה֙֙\t1\tmay your full wages come from Yahweh This is a poetic expression that is very similar to the previous sentence. Alternate translation: “May Yahweh fully give to you everything that you deserve” (See: [[rc://en/ta/man/translate/figs-parallelism]], [Doublet](../figs-doublet/01.md))

@RobH123 RobH123 self-assigned this Sep 22, 2020
@RobH123 RobH123 added the bug Something isn't working label Sep 25, 2020
@RobH123 RobH123 linked a pull request Nov 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants