Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start on suggestions; allow disabling of known issues #59

Merged
merged 25 commits into from
Nov 9, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Oct 27, 2020

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft October 27, 2020 21:02
@RobH123 RobH123 linked an issue Nov 2, 2020 that may be closed by this pull request
@RobH123 RobH123 changed the title Work on "suggestion" field for autocorrect Start on suggestions; allow disabling of known issues Nov 2, 2020
@RobH123 RobH123 marked this pull request as ready for review November 6, 2020 04:48
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #59 (b600d85) into master (bbba5f5) will increase coverage by 0.25%.
The diff coverage is 52.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   46.14%   46.39%   +0.25%     
==========================================
  Files          20       20              
  Lines        2241     2444     +203     
  Branches      716      789      +73     
==========================================
+ Hits         1034     1134     +100     
- Misses        742      818      +76     
- Partials      465      492      +27     
Impacted Files Coverage Δ
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/getApi.js 11.83% <ø> (+1.18%) ⬆️
src/core/ta-reference-check.js 89.58% <ø> (-0.22%) ⬇️
src/core/utilities.js 14.28% <ø> (ø)
src/core/annotation-row-check.js 1.76% <2.00%> (-0.17%) ⬇️
src/core/yaml-text-check.js 2.22% <6.66%> (-1.86%) ⬇️
src/core/tn-links-check.js 52.34% <46.21%> (-16.73%) ⬇️
src/core/annotation-table-check.js 2.36% <50.00%> (-0.77%) ⬇️
src/core/field-text-check.js 57.69% <51.28%> (+1.87%) ⬆️
src/core/orig-quote-check.js 63.58% <73.52%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbba5f5...b600d85. Read the comment docs.

@RobH123
Copy link
Contributor Author

RobH123 commented Nov 6, 2020

@mandolyte @PhotoNomad0 Sorry for such a big PR. Lots of testing on real data and fine-tuning. Some changes to API.

Note especially that notices for known faults can now be disabled. See https://github.com/unfoldingWord/uw-content-validation/blob/RJHimprovements/src/demos/notice-processing-functions.js#L359 for that. Note that notices now require a username field to make this work -- see https://github.com/unfoldingWord/uw-content-validation/blob/RJHimprovements/src/demos/book-package-check/checkBookPackage.js#L231 for how I do that. The concept should still work if different files have different repo usernames. Note also that a repoCode field is also needed in the notices, e.g., UHB,UGNT,LT,ST,TA,TW. For existing tN and tQ, it's TN1 and TQ1. TN, TQ, and TWL are reserved for the new TSV repos. You can see the repoCode being added in this function.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 35 files at r1, 27 of 48 files at r2, 25 of 25 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@mandolyte mandolyte merged commit a059649 into master Nov 9, 2020
@mandolyte mandolyte deleted the RJHimprovements branch November 9, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants