-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start on suggestions; allow disabling of known issues #59
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 46.14% 46.39% +0.25%
==========================================
Files 20 20
Lines 2241 2444 +203
Branches 716 789 +73
==========================================
+ Hits 1034 1134 +100
- Misses 742 818 +76
- Partials 465 492 +27
Continue to review full report at Codecov.
|
@mandolyte @PhotoNomad0 Sorry for such a big PR. Lots of testing on real data and fine-tuning. Some changes to API. Note especially that notices for known faults can now be disabled. See https://github.com/unfoldingWord/uw-content-validation/blob/RJHimprovements/src/demos/notice-processing-functions.js#L359 for that. Note that notices now require a username field to make this work -- see https://github.com/unfoldingWord/uw-content-validation/blob/RJHimprovements/src/demos/book-package-check/checkBookPackage.js#L231 for how I do that. The concept should still work if different files have different repo usernames. Note also that a repoCode field is also needed in the notices, e.g., UHB,UGNT,LT,ST,TA,TW. For existing tN and tQ, it's TN1 and TQ1. TN, TQ, and TWL are reserved for the new TSV repos. You can see the repoCode being added in this function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 35 of 35 files at r1, 27 of 48 files at r2, 25 of 25 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)
This change is