Bug fixes

[RobH123]

Closing manifest file errors

---

This change is 

[codecov]

Codecov Report

Merging #113 (81f716c) into master (ff13706) will decrease coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   47.05%   46.29%   -0.76%     
==========================================
  Files          22       22              
  Lines        2782     2782              
  Branches      892      892              
==========================================
- Hits         1309     1288      -21     
- Misses        925      942      +17     
- Partials      548      552       +4     

Impacted Files	Coverage Δ
src/core/manifest-text-check.js	4.81% <100.00%> (ø)
src/core/getApi.js	10.71% <0.00%> (-12.50%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff13706...81f716c. Read the comment docs.

[mandolyte]

Since these functions use a straight parameter list, username is not optional. If this is a breaking change, you should make this part of a 1.0.0 (or 1.0.0-alpha1) release.

[ancientTexts-net]

---

src/demos/file-check/checkFileContents.js, line 74 at r2 (raw file):

    checkFileResult = checkPlainText('text', filename, fileContent, ourCFLocation, checkingOptions);
  else if (filenameLower === 'manifest.yaml')
    // TODO: Does the branch need to be passed in as a parameter???

@RobH123 @mandolyte

Do we need to resolve this TODO before merging?
What do you think?

Thanks

[ancientTexts-net]

Reviewed 2 of 7 files at r1, 6 of 7 files at r2.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @ancientTexts-net and @RobH123)

[ancientTexts-net]

---

src/demos/notice-processing-functions.js, line 106 at r3 (raw file):

    // It only really makes sense if the debugChain is enabled
    if (givenNoticeObject.noticeList && givenNoticeObject.noticeList.length)
        if (givenNoticeObject.noticeList.length > 8000)

???

[ancientTexts-net]

Reviewed 6 of 7 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RobH123)