Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing to disable notices when called from tC Create #117

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jan 6, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft January 6, 2021 08:02
@RobH123
Copy link
Contributor Author

RobH123 commented Jan 6, 2021

Ummh, this is a problem with failing tests here after I did a yarn upgrade. Tests pass fine on my laptop but no longer pass here. How do I debug that? Disable each package upgrade one-by-one?

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #117 (eeab47c) into master (cfd0e49) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   46.29%   46.19%   -0.11%     
==========================================
  Files          22       22              
  Lines        2782     2784       +2     
  Branches      892      893       +1     
==========================================
- Hits         1288     1286       -2     
  Misses        942      942              
- Partials      552      556       +4     
Impacted Files Coverage Δ
src/core/disabled-notices.js 75.00% <57.14%> (-25.00%) ⬇️
src/core/tn-table-text-check.js 65.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd0e49...eeab47c. Read the comment docs.

@RobH123 RobH123 changed the title Various fixes Fix failing to disable notices when called from tC Create Jan 7, 2021
@RobH123 RobH123 marked this pull request as ready for review January 7, 2021 03:12
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r3.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @ancientTexts-net and @mandolyte)

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)

@mandolyte mandolyte merged commit 2eeee44 into master Jan 7, 2021
@mandolyte mandolyte deleted the RJHimprovements branch January 7, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants