-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing to disable notices when called from tC Create #117
Conversation
Ummh, this is a problem with failing tests here after I did a yarn upgrade. Tests pass fine on my laptop but no longer pass here. How do I debug that? Disable each package upgrade one-by-one? |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 46.29% 46.19% -0.11%
==========================================
Files 22 22
Lines 2782 2784 +2
Branches 892 893 +1
==========================================
- Hits 1288 1286 -2
Misses 942 942
- Partials 552 556 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r3.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @ancientTexts-net and @mandolyte)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)
This change is