Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next set of improvements #123

Merged
merged 9 commits into from
Jan 25, 2021
Merged

Next set of improvements #123

merged 9 commits into from
Jan 25, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jan 11, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft January 11, 2021 05:38
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #123 (d369a41) into master (23b76b2) will increase coverage by 0.32%.
The diff coverage is 52.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   46.17%   46.50%   +0.32%     
==========================================
  Files          22       22              
  Lines        2800     2901     +101     
  Branches      903      948      +45     
==========================================
+ Hits         1293     1349      +56     
- Misses        945      970      +25     
- Partials      562      582      +20     
Impacted Files Coverage Δ
src/core/BCS-usfm-grammar-check.js 52.30% <0.00%> (ø)
src/core/annotation-row-check.js 2.55% <0.00%> (ø)
src/core/annotation-table-check.js 2.27% <0.00%> (ø)
src/core/disabled-notices.js 72.22% <0.00%> (ø)
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/getApi.js 10.71% <0.00%> (ø)
src/core/manifest-text-check.js 4.81% <0.00%> (ø)
src/core/usfm-js-check.js 11.76% <0.00%> (ø)
src/core/yaml-text-check.js 1.40% <0.00%> (ø)
src/core/utilities.js 30.00% <54.54%> (+15.71%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b76b2...d369a41. Read the comment docs.

@RobH123 RobH123 linked an issue Jan 22, 2021 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as ready for review January 25, 2021 03:45
@RobH123 RobH123 requested review from PhotoNomad0, ancientTexts-net and mandolyte and removed request for PhotoNomad0 January 25, 2021 03:45
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 30 of 43 files at r1, 14 of 14 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)

@mandolyte mandolyte merged commit 06ae824 into master Jan 25, 2021
@mandolyte mandolyte deleted the RJHimprovements branch January 25, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch misspelling of USFM attributes
2 participants