-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent 621 punct at end for UGNT ellipsis #128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 46.19% 46.21% +0.02%
==========================================
Files 22 22
Lines 2784 2787 +3
Branches 893 894 +1
==========================================
+ Hits 1286 1288 +2
- Misses 942 943 +1
Partials 556 556
Continue to review full report at Codecov.
|
Really, this was just a one-character fix (adding an ellipsis to a string in a comparison), but I struggled to try to find out why tests pass locally, but fail here. (Still don't fully understand it unfortunately, but they're both passing at present.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)
@RobH123 reviewed & merged. I'll let you publish to NPM when you are ready. |
There are four ellipsis in the UGNT and Alan Bunning confirms that they are intentional (partial OT quotes).
Fixes 2nd part of unfoldingWord/tc-create-app#574
This change is