Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #130

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Fix bugs #130

merged 3 commits into from
Jan 18, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jan 17, 2021

This change is Reviewable

@RobH123 RobH123 self-assigned this Jan 17, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #130 (37a4964) into master (24fcef6) will decrease coverage by 0.03%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   46.21%   46.17%   -0.04%     
==========================================
  Files          22       22              
  Lines        2787     2800      +13     
  Branches      894      903       +9     
==========================================
+ Hits         1288     1293       +5     
- Misses        943      945       +2     
- Partials      556      562       +6     
Impacted Files Coverage Δ
src/core/annotation-table-check.js 2.27% <0.00%> (ø)
src/core/orig-quote-check.js 61.53% <41.17%> (-1.60%) ⬇️
src/core/disabled-notices.js 72.22% <50.00%> (-2.78%) ⬇️
src/core/tn-table-text-check.js 65.41% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fcef6...37a4964. Read the comment docs.

@RobH123 RobH123 marked this pull request as draft January 17, 2021 23:05
@RobH123 RobH123 marked this pull request as ready for review January 18, 2021 02:29
@RobH123
Copy link
Contributor Author

RobH123 commented Jan 18, 2021

Turned out not to be any real bugs, but mostly improving the messages to give more information to the content team, plus some minor feature improvements, and some additional logging to help debug notice disabling in the App.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)

@mandolyte mandolyte merged commit 23b76b2 into master Jan 18, 2021
@mandolyte mandolyte deleted the FixBugs branch January 18, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants