Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next round of improvements to markdown checks #142

Merged
merged 8 commits into from
Feb 10, 2021
Merged

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Feb 5, 2021

This change is Reviewable

@RobH123 RobH123 linked an issue Feb 5, 2021 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as draft February 5, 2021 02:13
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #142 (449499b) into master (79c9680) will increase coverage by 0.02%.
The diff coverage is 42.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   45.46%   45.48%   +0.02%     
==========================================
  Files          22       22              
  Lines        3073     3100      +27     
  Branches      991     1006      +15     
==========================================
+ Hits         1397     1410      +13     
- Misses       1060     1063       +3     
- Partials      616      627      +11     
Impacted Files Coverage Δ
src/core/BCS-usfm-grammar-check.js 54.66% <ø> (+2.35%) ⬆️
src/core/annotation-row-check.js 2.53% <0.00%> (-0.03%) ⬇️
src/core/file-text-check.js 91.17% <ø> (ø)
src/core/getApi.js 10.71% <ø> (ø)
src/core/manifest-text-check.js 4.81% <ø> (ø)
src/core/markdown-file-contents-check.js 90.38% <ø> (ø)
src/core/orig-quote-check.js 62.08% <ø> (ø)
src/core/ta-reference-check.js 89.58% <ø> (ø)
src/core/usfm-js-check.js 11.76% <ø> (ø)
src/core/usfm-text-check.js 56.34% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c9680...449499b. Read the comment docs.

This was linked to issues Feb 5, 2021
@RobH123 RobH123 changed the title Add md format mismatch warnings which tX already found Next round of improvements to markdown checks Feb 5, 2021
@RobH123 RobH123 linked an issue Feb 5, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Feb 8, 2021 that may be closed by this pull request
@RobH123
Copy link
Contributor Author

RobH123 commented Feb 8, 2021

Probably good to get this fixes and small enhancements out before we start making changes to TSV files.

@RobH123 RobH123 marked this pull request as ready for review February 8, 2021 18:43
@RobH123 RobH123 requested a review from mandolyte February 8, 2021 18:43
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 26 files at r1, 24 of 26 files at r2, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mandolyte mandolyte merged commit 5410897 into master Feb 10, 2021
@mandolyte mandolyte deleted the RJHimprovements branch February 10, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants