New version with changed API for updated TSV formats

[RobH123]

This change is 

[codecov]

Codecov Report

Merging #147 (1da630b) into master (5410897) will increase coverage by 1.22%.
The diff coverage is 38.58%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   45.48%   46.71%   +1.22%     
==========================================
  Files          22       26       +4     
  Lines        3100     4044     +944     
  Branches     1006     1312     +306     
==========================================
+ Hits         1410     1889     +479     
- Misses       1063     1369     +306     
- Partials      627      786     +159     

Impacted Files	Coverage Δ
src/core/disabled-notices.js	72.22% <ø> (ø)
src/core/field-link-check.js	0.00% <0.00%> (ø)
src/core/getApi.js	10.71% <0.00%> (ø)
src/core/usfm-js-check.js	11.76% <0.00%> (ø)
src/core/twl-tsv6-table-check.js	2.25% <2.25%> (ø)
src/core/twl-tsv6-row-check.js	2.52% <2.52%> (ø)
src/core/manifest-text-check.js	4.59% <6.66%> (-0.23%)	⬇️
src/core/yaml-text-check.js	1.36% <10.00%> (-0.04%)	⬇️
src/core/usfm-text-check.js	55.47% <27.48%> (-0.87%)	⬇️
src/core/notes-links-check.js	28.66% <28.66%> (ø)
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5410897...1da630b. Read the comment docs.

[mandolyte]

@RobH123 Could you connect this PR with an issue please? Our QA practices have standardized on this so that they and I as a reviewer have context and understanding of the changes.

I see this is still in draft mode, but I also wanted to ask whether this code would automatically detect whether a resource was in the new TSV format or not... in other words, will this be a breaking change that we have to coordinate deployment with the data format change.

Thanks!

[RobH123]

Could you connect this PR with an issue please? Our QA practices have standardized on this so that they and I as a reviewer have context and understanding of the changes.

@mandolyte There were already six linked issues and I just added another one. I apologise from the ongoingness of this PR -- it's partly coz the new TSV formats were only finally approved yesterday, and partly because of how I work -- flitting back and forth from publishing/content work to software development and adding/fine-tuning checks as I understand the need for them during the publishing. Also partly coz I hadn't been able to devote a big-enough block of time to thorough testing of the new format checks.

[RobH123]

I see this is still in draft mode, but I also wanted to ask whether this code would automatically detect whether a resource was in the new TSV format or not... in other words, will this be a breaking change that we have to coordinate deployment with the data format change.

@mandolyte This big change is certainly a breaking change to the APIs (as reflected in the title and version number). That's partly why I wanted to also work on some issues/improvements that had been waiting for a break.

As to implementation of new formats in tC Create and your BP apps, I don't think that the roll-out has been fully planned yet. But here in general, each different TSV format has a different checking function. For the demos, I choose the formats here where TN2 and TQ2 and TWL will each cause the new checking functions to be called.

[RobH123]

I think this is finally working good enough to be a first attempt at v2

[mandolyte]

Reviewed 56 of 84 files at r2, 30 of 30 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved