-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new TSV filename style; other small fixes #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
===========================================
- Coverage 46.71% 36.26% -10.45%
===========================================
Files 26 27 +1
Lines 4044 4059 +15
Branches 1312 1314 +2
===========================================
- Hits 1889 1472 -417
- Misses 1369 1655 +286
- Partials 786 932 +146
Continue to review full report at Codecov.
|
@mandolyte, @birchamp would you know what main issue we can connect this PR to? |
This is a 2.0.0 issue |
@birchamp can we take the 1.2 tag from this PR? |
@mandolyte Could you please look at this PR before I start on the next round of content publishing. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 6 files at r1, 35 of 35 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RobH123)
src/core/defaults.js, line 7 at r2 (raw file):
'LT', 'ST', 'TA', 'TW', 'TWL', 'TN', 'TN2', 'TQ', 'TQ2',
are still going to need the "...2" repo codes now?
@mandolyte We still need to distinguish between the old and new TN and TQ formats for validation I think. Maybe for the longer term, TN should be TN1, then TN2 could be just TN, and similarly for TQ? It's going to be tricky, I think, over the next year or so as things change around, and I still expect many changes to this CV package as various tool and content migration decisions are made one by one. |
This change is