Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct two important bugs plus some small improvements #167

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Apr 19, 2021

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #167 (d3cfee9) into master (add5c47) will decrease coverage by 0.00%.
The diff coverage is 51.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   35.97%   35.97%   -0.01%     
==========================================
  Files          27       27              
  Lines        4094     4103       +9     
  Branches     1323     1325       +2     
==========================================
+ Hits         1473     1476       +3     
- Misses       1680     1686       +6     
  Partials      941      941              
Impacted Files Coverage Δ
src/core/getApi.js 10.46% <0.00%> (-0.19%) ⬇️
src/core/notes-tsv7-row-check.js 2.66% <0.00%> (ø)
src/core/questions-tsv7-row-check.js 2.57% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 2.47% <0.00%> (ø)
src/core/notes-tsv7-table-check.js 2.23% <14.28%> (-0.02%) ⬇️
src/core/questions-tsv7-table-check.js 2.23% <14.28%> (-0.02%) ⬇️
src/core/twl-tsv6-table-check.js 2.23% <14.28%> (-0.02%) ⬇️
src/core/orig-quote-check.js 64.62% <96.42%> (+0.33%) ⬆️
src/core/tn-tsv9-row-check.js 71.49% <100.00%> (ø)
src/core/tn-tsv9-table-check.js 65.92% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add5c47...d3cfee9. Read the comment docs.

@RobH123 RobH123 linked an issue Apr 26, 2021 that may be closed by this pull request
@RobH123 RobH123 changed the title Address issue #120 Correct two important bugs plus some small improvements Apr 26, 2021
@RobH123 RobH123 requested a review from mandolyte April 26, 2021 22:20
@RobH123 RobH123 marked this pull request as ready for review April 26, 2021 22:20
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 9 files at r1, 12 of 12 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 525e98a into master Apr 29, 2021
@mandolyte mandolyte deleted the new.2.1.2 branch April 29, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants