Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New.2.1.3 #173

Merged
merged 16 commits into from
May 24, 2021
Merged

New.2.1.3 #173

merged 16 commits into from
May 24, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Apr 29, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft April 29, 2021 23:05
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #173 (caf079c) into master (525e98a) will increase coverage by 0.38%.
The diff coverage is 52.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   35.97%   36.36%   +0.38%     
==========================================
  Files          27       27              
  Lines        4103     4169      +66     
  Branches     1325     1341      +16     
==========================================
+ Hits         1476     1516      +40     
- Misses       1686     1706      +20     
- Partials      941      947       +6     
Impacted Files Coverage Δ
src/core/disabled-notices.js 72.22% <ø> (ø)
src/core/getApi.js 10.46% <0.00%> (ø)
src/core/notes-tsv7-row-check.js 2.66% <0.00%> (ø)
src/core/questions-tsv7-row-check.js 2.57% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 2.47% <0.00%> (ø)
src/core/notes-links-check.js 27.82% <25.00%> (ø)
src/core/notes-tsv7-table-check.js 2.22% <25.00%> (-0.02%) ⬇️
src/core/questions-tsv7-table-check.js 2.22% <25.00%> (-0.02%) ⬇️
src/core/twl-tsv6-table-check.js 2.22% <25.00%> (-0.02%) ⬇️
src/core/BCS-usfm-grammar-check.js 28.39% <33.33%> (-26.28%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525e98a...caf079c. Read the comment docs.

@RobH123 RobH123 linked an issue May 9, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue May 9, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue May 24, 2021 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as ready for review May 24, 2021 01:49
@RobH123 RobH123 requested a review from mandolyte May 24, 2021 01:49
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1, 58 of 58 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit d843e99 into master May 24, 2021
@mandolyte mandolyte deleted the new.2.1.3 branch May 24, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants