Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New.2.1.4 #175

Merged
merged 14 commits into from
Jun 11, 2021
Merged

New.2.1.4 #175

merged 14 commits into from
Jun 11, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented May 26, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft May 26, 2021 05:41
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #175 (aea8ae4) into master (d843e99) will decrease coverage by 0.48%.
The diff coverage is 6.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   36.36%   35.88%   -0.49%     
==========================================
  Files          27       27              
  Lines        4169     4222      +53     
  Branches     1341     1359      +18     
==========================================
- Hits         1516     1515       -1     
- Misses       1706     1742      +36     
- Partials      947      965      +18     
Impacted Files Coverage Δ
src/core/notes-tsv7-row-check.js 2.63% <0.00%> (-0.04%) ⬇️
src/core/orig-quote-check.js 69.87% <ø> (ø)
src/core/questions-tsv7-row-check.js 2.28% <0.00%> (-0.30%) ⬇️
src/core/tn-tsv9-row-check.js 71.49% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 2.47% <0.00%> (ø)
src/core/usfm-js-check.js 11.76% <0.00%> (ø)
src/core/usfm-text-check.js 55.62% <0.00%> (ø)
src/core/manifest-text-check.js 4.12% <4.76%> (-0.43%) ⬇️
src/core/notes-links-check.js 27.08% <6.89%> (-0.75%) ⬇️
src/core/BCS-usfm-grammar-check.js 27.84% <100.00%> (-0.55%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d843e99...aea8ae4. Read the comment docs.

@RobH123 RobH123 linked an issue May 26, 2021 that may be closed by this pull request
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 12 files at r1, 12 of 12 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@RobH123 RobH123 marked this pull request as ready for review June 10, 2021 22:41
@RobH123
Copy link
Contributor Author

RobH123 commented Jun 10, 2021

Thanks for that review @mandolyte. I just pushed some very small changes that were sitting on my laptop and updated the version number ready for publishing if you wouldn't mind doing another quick review. Thanks.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 0d4ad64 into master Jun 11, 2021
@mandolyte mandolyte deleted the new.2.1.4 branch June 11, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check repos for files not in manifest
2 participants