Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New.2.1.5 #177

Merged
merged 36 commits into from
Jul 7, 2021
Merged

New.2.1.5 #177

merged 36 commits into from
Jul 7, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jun 13, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft June 13, 2021 23:52
@RobH123 RobH123 linked an issue Jun 14, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #177 (bc139ea) into master (b66cf83) will increase coverage by 0.60%.
The diff coverage is 29.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   35.88%   36.48%   +0.60%     
==========================================
  Files          27       27              
  Lines        4222     3670     -552     
  Branches     1359     1381      +22     
==========================================
- Hits         1515     1339     -176     
+ Misses       1742     1382     -360     
+ Partials      965      949      -16     
Impacted Files Coverage Δ
src/core/defaults.js 100.00% <ø> (ø)
src/core/disabled-notices.js 72.22% <ø> (ø)
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/file-text-check.js 78.57% <0.00%> (-13.33%) ⬇️
src/core/notes-tsv7-table-check.js 2.54% <0.00%> (+0.32%) ⬆️
src/core/plain-text-check.js 60.67% <0.00%> (-2.26%) ⬇️
src/core/questions-tsv7-row-check.js 2.95% <0.00%> (+0.67%) ⬆️
src/core/questions-tsv7-table-check.js 2.54% <0.00%> (+0.32%) ⬆️
src/core/twl-tsv6-row-check.js 3.12% <0.00%> (+0.64%) ⬆️
src/core/twl-tsv6-table-check.js 2.54% <0.00%> (+0.32%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66cf83...bc139ea. Read the comment docs.

@RobH123 RobH123 linked an issue Jun 18, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Jun 18, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Jun 21, 2021 that may be closed by this pull request
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 31 of 44 files at r1, 22 of 22 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@RobH123 RobH123 linked an issue Jun 29, 2021 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as ready for review July 2, 2021 06:45
@RobH123 RobH123 linked an issue Jul 5, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Jul 6, 2021 that may be closed by this pull request
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 77 of 77 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 7ba891d into master Jul 7, 2021
@mandolyte mandolyte deleted the new.2.1.5 branch July 7, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment